Skip to content

Add Size Credit #2248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add Size Credit #2248

wants to merge 1 commit into from

Conversation

jaazinn
Copy link

@jaazinn jaazinn commented Apr 23, 2025

What changed? Why?

Re-submitting with terms of service on the app page per feedback. See prior comments on PR #2090

Notes to reviewers

How has it been tested?

Locally

Have you tested the following pages?

Ecosystem is the only page affected.

BaseWeb

  • [] base.org
  • [] base.org/names
  • [] base.org/builders
  • [] base.org/ecosystem
  • [] base.org/name/jesse
  • [] base.org/manage-names
  • [] base.org/resources

BaseDocs

  • [] docs.base.org
  • [] docs sub-pages

Copy link

vercel bot commented Apr 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-base-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 23, 2025 2:35pm

Copy link

vercel bot commented Apr 23, 2025

@jaazinn is attempting to deploy a commit to the Coinbase Team on Vercel.

A member of the Team first needs to authorize it.

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Apr 23, 2025

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/2
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 1
Sum 2

@wbnns wbnns added the base ecosystem review This is ecosystem related label May 8, 2025
@wbnns
Copy link
Contributor

wbnns commented May 9, 2025

@jaazinn Hello, our review team was unable to make the sign transaction to log in using Coinbase Wallet. It appears there may be a bug. Please resubmit for review once this has been fixed. 🙏

@wbnns wbnns closed this May 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
base ecosystem review This is ecosystem related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants